-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bindings): building package #1113
fix(bindings): building package #1113
Conversation
Test Results (CI)556 tests ±0 556 ✅ ±0 1h 42m 15s ⏱️ + 9m 9s Results for commit 1c71647. ± Comparison against base commit 001f797. This pull request removes 36 and adds 36 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
1298016
to
1aa8cd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick test this doesnt break any of the WebUIs. LGTM
I have added all generated files (from npm run build command) to .gitignore file - this should prevent from situations where released package comes from older builds.
Was the gitignore change removed? Just checking if we should continue to run npm run build
when types change.
Maybe we just need to add a step to build the bindings before running CI - but we can leave that for another PR
Yes I have reverted changes to the |
Description
Tari.js is depending on this package but after inspecting it's dependencies I found issues with bindings package like incorrect package.json deceleration and project structure.
Motivation and Context
This PR is necessary to also fix Tari.js which throws errors in others project depending on it with error message that Tari.js is missing types declarations.
How Has This Been Tested?
Locally build bindings and imported it to local Tari.js and after that imported Tari.js to the Tari-Universe and checked if application was working as expected.
What process can a PR reviewer use to test or verify this change?
Build it locally with
npm run build
command and use it as dependency in other projects.Breaking Changes
Some types have changed their name to distinguish from each other and everything now it's exported directly from main file
index.ts
so imports likeshould be now: