feat(consensus): optionally configure max block time #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
reviewed
Jul 29, 2024
therealdannzor
force-pushed
the
feat-consensus-block-time-config
branch
from
11b750d to
f30c3a9
Compare
sdbondi
approved these changes
Jul 29, 2024
sdbondi
approved these changes
Jul 29, 2024
| @@ -26,6 +26,7 @@ pub struct ConsensusConstants { | |||
| pub committee_size: u32, | |||
| pub max_base_layer_blocks_ahead: u64, | |||
| pub max_base_layer_blocks_behind: u64, | |||
| pub pacemaker_max_base_time: std::time::Duration, | |||
Merged
via the queue into
tari-project:development
with commit Jul 29, 2024
f0beea4
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update consensus constants to include the (maximum) base block time, a component of the GST before a leader fails.
Resolves #1088
Motivation and Context
Currently it is hard coded to 10 seconds. This will make it configurable.
How Has This Been Tested?
Unit and integration tests.
What process can a PR reviewer use to test or verify this change?
Breaking Changes