Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): remove build step when publishing typescript-bindings #1096

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

mrnaveira
Copy link
Collaborator

Description

Removed the npm build step on typescript-bindings npm publish CI job

Motivation and Context

On #1093 we introduced a step to build the npm package for both wallet_jrpc_client and typescript-bindings.

We shouldn't include that step for typescript-bindings as we can assume it's already built (there are checks for that) and the build runs a custom script that builds all of the rust project using cargo.

So this PR removes the npm build step on typescript-bindings npm publish CI job. We only need it for wallet_jrpc_client

How Has This Been Tested?

Does not apply

What process can a PR reviewer use to test or verify this change?

Does not apply

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

@mrnaveira mrnaveira requested a review from a team as a code owner July 26, 2024 13:30
Copy link

github-actions bot commented Jul 26, 2024

Test Results (CI)

96 tests   - 446   95 ✅  - 447   43m 55s ⏱️ - 1h 0m 6s
14 suites  -  50    0 💤 ±  0 
 1 files    -   1    1 ❌ +  1 

For more details on these failures, see this check.

Results for commit 13153b3. ± Comparison against base commit 1c35d75.

This pull request removes 446 tests.
Scenario: Claim and transfer confidential assets via wallet daemon: tests/features/wallet_daemon.feature:90:3
Scenario: Claim base layer burn funds with wallet daemon: tests/features/claim_burn.feature:7:3
Scenario: Concurrent calls to the Counter template: tests/features/concurrency.feature:8:3
Scenario: Confidential transfer to unexisting account: tests/features/transfer.feature:164:3
Scenario: Counter template registration and invocation: tests/features/counter.feature:8:3
Scenario: Create account and transfer faucets via wallet daemon: tests/features/wallet_daemon.feature:8:3
Scenario: Create and mint account NFT: tests/features/wallet_daemon.feature:134:3
Scenario: Create resource and mint in one transaction: tests/features/nft.feature:74:3
Scenario: Double Claim base layer burn funds with wallet daemon. should fail: tests/features/claim_burn.feature:45:3
Scenario: EndEpoch command is used on epoch change: tests/features/epoch_change.feature:8:3
…

♻️ This comment has been updated with latest results.

Copy link
Contributor

@leet4tari leet4tari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@leet4tari leet4tari enabled auto-merge July 26, 2024 14:11
@leet4tari leet4tari added this pull request to the merge queue Jul 26, 2024
Merged via the queue into tari-project:development with commit 1700fa0 Jul 26, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants