Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): tari_template_lib resource builders not showing on rust docs #1094

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

mrnaveira
Copy link
Collaborator

Description

Set to pub the visibility of resource builder modules in tari_template_lib

Motivation and Context

Currently FungibleResourceBuilder, NonFungibleResourceBuilder and ConfidentialResourceBuilder don't show up in tari_template_lib docs.

This happened because the visibility of the modules containing those structs was not public, so this PR sets the visibility to public.

How Has This Been Tested?

Manually by running cargo doc --open on the tari_template_lib crate

What process can a PR reviewer use to test or verify this change?

See previous section

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

Copy link

github-actions bot commented Jul 26, 2024

Test Results (CI)

542 tests  ±0   542 ✅ ±0   2h 46m 51s ⏱️ + 1h 2m 50s
 64 suites ±0     0 💤 ±0 
  2 files   ±0     0 ❌ ±0 

Results for commit 418c85a. ± Comparison against base commit 1c35d75.

♻️ This comment has been updated with latest results.

Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sdbondi sdbondi added this pull request to the merge queue Jul 29, 2024
Merged via the queue into tari-project:development with commit 359dd6e Jul 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants