feat(swarm): allow custom listen IP configuration #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
swarm-config-listen-ip
branch
from
0dc129f to
50ac436
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows user to specify
listen_ipin extra args for the instance to override the IP address used for listeners (JSON-rpc, web etc)Log target for stdout output of all instances uses the instance name to be consistent with the web UI
Greatly improve instance log output
Motivation and Context
This feature has been requested for use with docker.
extra_args is not named well and has been renamed to
settings. extra_args is still accepted for backwards compatibiltyHow Has This Been Tested?
By adding
listen_ip = "0.0.0.0"to extra_args for the validator node.What process can a PR reviewer use to test or verify this change?
As above, works with all instances that have listeners
Breaking Changes