Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swarm): reuse allocated ports after restart #1056

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jun 20, 2024

Description

uses previously allocated ports when restarting an instance

Motivation and Context

If an instance was stopped and started, it would receive new ports, causing other instances that may depend on the previous ports to break. This PR reuses the previously assigned ports for the instance on restart.

How Has This Been Tested?

Manually

What process can a PR reviewer use to test or verify this change?

Click stop then start on an instance, ports should remain the same.

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

Copy link

Test Results (CI)

538 tests  ±0   538 ✅ ±0   1h 53m 35s ⏱️ - 27m 21s
 64 suites ±0     0 💤 ±0 
  2 files   ±0     0 ❌ ±0 

Results for commit bc20793. ± Comparison against base commit 0ebb1fb.

@sdbondi sdbondi added this pull request to the merge queue Jun 21, 2024
Merged via the queue into tari-project:development with commit 7b523be Jun 21, 2024
11 checks passed
@sdbondi sdbondi deleted the swarm-reuse-allocated-ports branch June 21, 2024 15:48
sdbondi added a commit to sdbondi/tari-dan that referenced this pull request Jun 24, 2024
* development:
  feat(consensus): proposed block parked and ready event (tari-project#1055)
  fix(swarm): reuse allocated ports after restart (tari-project#1056)
  fix(indexer): reuse validator RPC sessions (tari-project#1057)
  fix(indexer): clippy fixes (tari-project#1052)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants