-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: fix epoch database structure #1034
Merged
stringhandler
merged 44 commits into
tari-project:development
from
stringhandler:st-fix-epoch-registration
May 15, 2024
Merged
refactor!: fix epoch database structure #1034
stringhandler
merged 44 commits into
tari-project:development
from
stringhandler:st-fix-epoch-registration
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dan_layer/epoch_manager/src/base_layer/base_layer_epoch_manager.rs # dan_layer/epoch_manager/src/base_layer/epoch_manager_service.rs # dan_layer/storage/src/global/backend_adapter.rs # dan_layer/storage/src/global/validator_node_db.rs # dan_layer/storage_sqlite/migrations/2024-04-01-121212_add_sidechain_id/up.sql # dan_layer/storage_sqlite/src/global/backend_adapter.rs # dan_layer/storage_sqlite/tests/global_db.rs
Test Results (CI)532 tests - 1 532 ✅ - 1 1h 43m 46s ⏱️ - 39m 47s Results for commit 96a13cf. ± Comparison against base commit 533d82e. This pull request removes 15 and adds 14 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
stringhandler
changed the title
refactor: fix epoch database structure
refactor!: fix epoch database structure
May 15, 2024
mrnaveira
previously approved these changes
May 15, 2024
mrnaveira
approved these changes
May 15, 2024
Merged
via the queue into
tari-project:development
with commit May 15, 2024
c2aee34
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the epoch, validator and committee structure in the global database.
Motivation and Context
Previously, validator nodes did not deregister and this resulted in a bug that caused the committees for epochs to not be correct.
How Has This Been Tested?
Existing tests, and manual testing
Breaking Changes
BREAKING CHANGE: Data directory must be cleaned