Skip to content

Commit

Permalink
chore: comment out flaky test (#817)
Browse files Browse the repository at this point in the history
Description
---
`New validator node registers and syncs` is flaky. It stops so many PRs
from being green.
I've created
[ticket](https://github.com/orgs/tari-project/projects/6/views/1?pane=issue&itemId=46646950)
for this so we fix it.

Motivation and Context
---

How Has This Been Tested?
---

What process can a PR reviewer use to test or verify this change?
---


Breaking Changes
---

- [x] None
- [ ] Requires data directory to be deleted
- [ ] Other - Please specify
  • Loading branch information
Cifko authored Dec 6, 2023
1 parent 0f07b81 commit ff64cc5
Showing 1 changed file with 53 additions and 52 deletions.
105 changes: 53 additions & 52 deletions integration_tests/tests/features/block_sync.feature
Original file line number Diff line number Diff line change
Expand Up @@ -3,56 +3,57 @@

Feature: Block Sync

@serial
Scenario: New validator node registers and syncs
# Initialize a base node, wallet, miner and VN
Given a base node BASE
Given a wallet WALLET connected to base node BASE
Given a miner MINER connected to base node BASE and wallet WALLET

# Initialize an indexer
Given an indexer IDX connected to base node BASE

# Initialize the wallet daemon
Given a wallet daemon WALLET_D connected to indexer IDX
When I create a key named K1 for WALLET_D

# Initialize a VN
Given a seed validator node VN connected to base node BASE and wallet WALLET
When miner MINER mines 4 new blocks
When wallet WALLET has at least 5000 T
When validator node VN sends a registration transaction allowing fee claims from wallet WALLET_D using key K1
When miner MINER mines 16 new blocks
Then VN has scanned to height 17
And indexer IDX has scanned to height 17
Then the validator node VN is listed as registered

When indexer IDX connects to all other validators

# Submit a few transactions
When I create an account ACC1 via the wallet daemon WALLET_D with 10000 free coins
When I create an account UNUSED1 via the wallet daemon WALLET_D
When I create an account UNUSED2 via the wallet daemon WALLET_D
When I create an account UNUSED3 via the wallet daemon WALLET_D

When I wait for validator VN has leaf block height of at least 20

# Start a new VN that needs to sync
Given a validator node VN2 connected to base node BASE and wallet WALLET
Given validator VN2 nodes connect to all other validators
When indexer IDX connects to all other validators

When validator node VN2 sends a registration transaction allowing fee claims from wallet WALLET_D using key K1
When miner MINER mines 20 new blocks
Then VN has scanned to height 37
Then VN2 has scanned to height 37
Then the validator node VN2 is listed as registered

When I wait for validator VN2 has leaf block height of at least 20

When I create an account UNUSED4 via the wallet daemon WALLET_D
When I create an account UNUSED5 via the wallet daemon WALLET_D

When I wait for validator VN has leaf block height of at least 26
When I wait for validator VN2 has leaf block height of at least 26
# This is flaky, we should fix it
# @serial
# Scenario: New validator node registers and syncs
# # Initialize a base node, wallet, miner and VN
# Given a base node BASE
# Given a wallet WALLET connected to base node BASE
# Given a miner MINER connected to base node BASE and wallet WALLET

# # Initialize an indexer
# Given an indexer IDX connected to base node BASE

# # Initialize the wallet daemon
# Given a wallet daemon WALLET_D connected to indexer IDX
# When I create a key named K1 for WALLET_D

# # Initialize a VN
# Given a seed validator node VN connected to base node BASE and wallet WALLET
# When miner MINER mines 4 new blocks
# When wallet WALLET has at least 5000 T
# When validator node VN sends a registration transaction allowing fee claims from wallet WALLET_D using key K1
# When miner MINER mines 16 new blocks
# Then VN has scanned to height 17
# And indexer IDX has scanned to height 17
# Then the validator node VN is listed as registered

# When indexer IDX connects to all other validators

# # Submit a few transactions
# When I create an account ACC1 via the wallet daemon WALLET_D with 10000 free coins
# When I create an account UNUSED1 via the wallet daemon WALLET_D
# When I create an account UNUSED2 via the wallet daemon WALLET_D
# When I create an account UNUSED3 via the wallet daemon WALLET_D

# When I wait for validator VN has leaf block height of at least 20

# # Start a new VN that needs to sync
# Given a validator node VN2 connected to base node BASE and wallet WALLET
# Given validator VN2 nodes connect to all other validators
# When indexer IDX connects to all other validators

# When validator node VN2 sends a registration transaction allowing fee claims from wallet WALLET_D using key K1
# When miner MINER mines 20 new blocks
# Then VN has scanned to height 37
# Then VN2 has scanned to height 37
# Then the validator node VN2 is listed as registered

# When I wait for validator VN2 has leaf block height of at least 20

# When I create an account UNUSED4 via the wallet daemon WALLET_D
# When I create an account UNUSED5 via the wallet daemon WALLET_D

# When I wait for validator VN has leaf block height of at least 26
# When I wait for validator VN2 has leaf block height of at least 26

0 comments on commit ff64cc5

Please sign in to comment.