fix: remove dotenv #132
Merged
fix: remove dotenv #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotenv was used for testing of the `build.js` script and is not needed anymore. Removing it for security reasons. There weren't any major concerns but some fat-finger errors may have led to deployment problems. The envars are set in the build environments (e.g. cloudflare) or have sane fallback defaults.
Deploying with
|
| Latest commit: |
8deff81
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7d0f9269.rfcs-6p3.pages.dev |
| Branch Preview URL: | https://remove-dotenv.rfcs-6p3.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotenv was used for testing of the
build.jsscript and is not needed anymore.Removing it for security reasons.
There weren't any major concerns but some fat-finger errors may have led to deployment problems. The envars are set in the build environments (e.g. cloudflare) or have sane fallback defaults.