Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Commit

Permalink
Merge pull request #4 from target/pull-request-template
Browse files Browse the repository at this point in the history
typo-fixes-pull-request-template
  • Loading branch information
CodeYogiCo authored Feb 10, 2022
2 parents 3dffbc1 + 500c4e3 commit a664fba
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 4 deletions.
20 changes: 20 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
### ❤ THANKS FOR YOUR PULL REQUEST

## Proposed change

Describe your change and communicate why we should accept the pull request. Links to issues are helpful too, if applicable.

## Types of changes

What types of changes is this pull request introducing to this plugin? _Put an `x` in the boxes that apply_

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

## Checklist

You can fill this out after creating your PR. _Put an `x` in the boxes that apply_

- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation (if appropriate)
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ jobs:
- name: check-format-on-pr
run: make format

- name: check-link-on-pr
- name: check-lint-on-pr
run: make lint
2 changes: 1 addition & 1 deletion internal/plugin/coverage/cobertura/report_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
func Test_silentlyCall(t *testing.T) {
assert.Panics(t, func() {
silentlyCall(func() error {
return errors.New("anuthing")
return errors.New("anything")
})
})
}
Expand Down
4 changes: 2 additions & 2 deletions scripts/start.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ module="${PARAMETER_MODULE:-}"
PARAMETER_RUN_DIR="${PARAMETER_RUN_DIR:-}"
branch="${VELA_PULL_REQUEST_TARGET:-}"

git config --global user.name "drone"
git config --global user.email "[email protected].com"
git config --global user.name "vela"
git config --global user.email "vela@xyz.com"


git fetch --no-tags origin "$branch"
Expand Down

0 comments on commit a664fba

Please sign in to comment.