Additional features #187
Open
Additional features #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jvshields
reviewed
Apr 22, 2024
| @@ -0,0 +1,74 @@ | |||
| 180.0,6.700000000000001e-20 | |||
There was a problem hiding this comment.
This file shouldn't really be added. I don't dislike the idea of a tutorial_data directory, but we should not duplicate data. You can point the h_minus_cross_section file to the existing data directory in the main stardis directory, and the docs already has a sun.mod file that can be pointed to as well.
Also, I would not really call the config files "data." Rather, maybe it's better structure to have the mesa_model be its own directory with both the notebook and the .yml file needed, and similar for the parallel stardis notebook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made 2 tutorials: one for running stardis in parallel and one for using it with a mesa model. There is another folder inside that holds all the files needed for running the examples. I completely forgot to commit while I was working but hopefully it won't be too hard to follow.