updated horizontal scrolling inside bs #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into fix-horizontal-scroll
JulianBissekkou
requested changes
Dec 16, 2024
Comment on lines
+135
to
+155
| return NotificationListener( | ||
| onNotification: (scrollNotification) { | ||
| if (scrollNotification is ScrollStartNotification && | ||
| scrollNotification.metrics.axis == Axis.horizontal) { | ||
| _isHorizontalScrolling = true; | ||
| } | ||
|
|
||
| if (scrollNotification is ScrollUpdateNotification && | ||
| scrollNotification.metrics.axis == Axis.horizontal) { | ||
| if (scrollNotification.dragDetails == null) { | ||
| _isHorizontalScrolling = false; | ||
| } | ||
| } | ||
|
|
||
| if (scrollNotification is ScrollEndNotification && | ||
| scrollNotification.metrics.axis == Axis.horizontal) { | ||
| _isHorizontalScrolling = false; | ||
| } | ||
|
|
||
| return false; | ||
| }, |
There was a problem hiding this comment.
I added some docs to this section because the bottom sheet is already complex :S
You can take the parts that you like.
return NotificationListener<ScrollNotification>(
// Disable vertical scrolling when the user is scrolling in a nested
// horizontal scroll view. Otherwise we should slightly move the bottom
// sheet vertically up and down which feels buggy.
onNotification: (notification) {
if (notification.metrics.axis != Axis.horizontal) {
return false;
}
if (notification is ScrollStartNotification) {
_isHorizontalScrolling = true;
}
if (notification is ScrollEndNotification) {
_isHorizontalScrolling = false;
}
// Drag details are null if the user started a scroll and the
// scrollview is continue to scroll without the user touching the view.
if (notification is ScrollUpdateNotification &&
notification.dragDetails == null) {
_isHorizontalScrolling = false;
}
return false;
},
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated horizontal scrolling