Lazy scan #166
Merged
Lazy scan #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelittlejohn
force-pushed
the
lazy-scan
branch
2 times, most recently
from
31e863f
to
3e6ad9b
Compare
kipz
approved these changes
May 13, 2024
Scanning with this function does not use span-reqs, but instead creates a lazy sequence and issues requests to get additional pages of data only when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this as a draft PR for now. I wrote this last year and I seem to remember that there was still something to work out around the tests proving that the lazy seq was not being realised. Can't remember if I resolved this or not.