[CI] Fix MacOS builds in Github Actions #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
This reverts commit 43473ed.
|
Macos is passing now: https://github.com/taocpp/json/actions/runs/12534486214/job/34955351051?pr=158 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
=======================================
Coverage 74.01% 74.01%
=======================================
Files 257 257
Lines 9191 9191
Branches 804 804
=======================================
Hits 6803 6803
Misses 1785 1785
Partials 603 603 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Github actions is moving their MacOS versions supported and XCode versions as well: https://github.com/actions/runner-images/tree/main?tab=readme-ov-file#available-images
This PR drops Macos 11 and 12 (both deprecated) and run only new versions. Plus, I dropped Debug builds, because Mac build in Github actions are most expansive (they take more time to be available).
The Cmake minimum change is due compatibility warning from CMake itself: https://github.com/uilianries/json/actions/runs/12534415695/job/34955186794#step:5:7
The CMake version 3.10 is from 2017, so I doubt users will complain about it.