Adding features to favourite option #528
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bartek532
reviewed
Sep 19, 2021
| <div className="icon"> | ||
| <Star aria-hidden="true" className="note-favorite" size={12} /> | ||
| <Star aria-hidden="true" className="note-favorite" size={12} fill="currentColor"/> |
There was a problem hiding this comment.
property that takes the value of color property, See docs
| @@ -121,7 +122,7 @@ export const NoteMenuBar = () => { | |||
| {!activeNote.scratchpad && ( | |||
| <> | |||
| <button className="note-menu-bar-button" onClick={favoriteNoteHandler}> | |||
| <Star aria-hidden="true" size={18} /> | |||
| <Star aria-hidden="true" size={18} fill={activeNote.favorite?"currentcolor":""} /> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi,
I have adjusted the styling of the favourite button in the note menubar.
I know this is a very small pull request, but we have to start somewhere ;).
I hope it is ok that I did not create an issue for this one.
Please read the Contribution Guidelines before opening a pull request. Include a summary of the change and which issue is fixed.
Closes # <-- link the issue number here
Browser checklist
This PR has been tested in the following browsers:
Testing checklist