Export Notes as PDF #504
Open
Export Notes as PDF #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@taniarascia Could you please review this PR ? |
|
Um are the devs going to do the reviews they apparently need to get this merged, because this is a pretty useful feature and it seems to have passed all the checks. |
taniarascia
reviewed
Aug 20, 2021
| @@ -118,12 +119,88 @@ function* syncSettings() { | |||
| } catch (error) {} | |||
| } | |||
|
|
|||
| export const getNoteTitle = (text: string): string => { | |||
There was a problem hiding this comment.
Instead of duplicating this code, it can be imported.
|
This is a great idea! However the app will only ever be deployed in "demo-mode", that is, client side only. This feature requires a Node app to be running. So either the button should be hidden in demo mode and is understood to only work on the self-hosted version, or it would have to work client-side only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request : #487
This PR adds the following:
Browser checklist
This PR has been tested in the following browsers:
Testing checklist