Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tangle lst pallet #36

Merged
merged 22 commits into from
Nov 4, 2024
Merged

Add tangle lst pallet #36

merged 22 commits into from
Nov 4, 2024

Conversation

1xstj
Copy link
Collaborator

@1xstj 1xstj commented Oct 9, 2024

Summary of changes
Changes introduced in this pull request:

@drewstone
Copy link
Contributor

What is the status here, especially with respect to implementing this in the front-end? Is the API settled?

@1xstj 1xstj marked this pull request as ready for review November 4, 2024 13:24
@1xstj 1xstj requested a review from drewstone as a code owner November 4, 2024 13:24
]
);

// when
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these comments I'm not understanding them lol

Copy link
Collaborator Author

@1xstj 1xstj Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its comments from parity :) https://github.com/paritytech/polkadot-sdk/blob/9353a2829d88ad620478d19ada000338d74274ef/substrate/frame/nomination-pools/src/tests.rs#L665

I think they meant like in math proofs, when balance = x, we execute this test and so on..

@drewstone drewstone merged commit 8efb5a4 into main Nov 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Update liquid staking pallets with pool creation/bond requirement
2 participants