fix(blueprint-proc-macro): fix bug where job IDs are not written in order to blueprint.json #542
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for debugging and fixing bugs as I see them.
For example, I got this error when submitting a keygen (job_id=0):
Failed to submit job: Runtime(Module(ModuleError(<Services::TypeCheck>)))When I checked the generated blueprint.json, the keygen job was the second element. So, when I set the job IDs to be in order with the blueprint.json file, that error went away. The real fix is to ensure the listed jobs are sorted by ID.