Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download Tangle binary against specific hash #537

Merged
merged 39 commits into from
Dec 10, 2024
Merged

Download Tangle binary against specific hash #537

merged 39 commits into from
Dec 10, 2024

Conversation

drewstone
Copy link
Contributor

No description provided.

@Tjemmmic Tjemmmic added the DO NOT MERGE Please do not merge this PR yet, even if it is ready label Dec 10, 2024
@drewstone
Copy link
Contributor Author

@Serial-ATA I merged your branch in here btw.

@drewstone drewstone mentioned this pull request Dec 10, 2024
Closed
@drewstone
Copy link
Contributor Author

CC @shekohex if you're able to parse this error more quickly than us.

@drewstone
Copy link
Contributor Author

Ah maybe forge isn't actually building it.

@drewstone
Copy link
Contributor Author

Ok some new changes @tbraun96 @Serial-ATA @Tjemmmic @shekohex

  • Adding logging of the node to the testing using RUST_LOG=debug. If you have naming suggestions lmk, currently some output from the node (most of it) gets logged to stderr.
  • There's a 3rd parameters to the new_test_ext... which specifies whether you want to use local or download tangle binary. This way we can test locally still if we need to add logging to pallets.

shekohex
shekohex requested changes Dec 10, 2024
View reviewed changes
cli/src/deploy.rs Outdated Show resolved Hide resolved
blueprint-test-utils/src/tangle/mod.rs Show resolved Hide resolved
blueprint-test-utils/src/tangle/mod.rs Outdated Show resolved Hide resolved
blueprint-test-utils/src/tangle/node.rs Outdated Show resolved Hide resolved
blueprint-test-utils/src/tangle/node.rs Show resolved Hide resolved
blueprint-test-utils/src/tangle/node.rs Outdated Show resolved Hide resolved
blueprint-test-utils/src/test_ext.rs Outdated Show resolved Hide resolved
blueprint-test-utils/src/test_ext.rs Show resolved Hide resolved
@drewstone drewstone merged commit 12da32d into main Dec 10, 2024
12 of 13 checks passed
@webb-spider webb-spider bot mentioned this pull request Dec 10, 2024
Merged
@Serial-ATA Serial-ATA deleted the drew/download-binary branch December 10, 2024 22:25
@webb-spider webb-spider bot mentioned this pull request Dec 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekohex shekohex shekohex approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE Please do not merge this PR yet, even if it is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@drewstone @shekohex @Tjemmmic @Serial-ATA @tbraun96