Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buggy testing process of test_from_xpublic_key #56

Open
wants to merge 73 commits into
base: master
Choose a base branch
from

Conversation

chenluyong
Copy link

Fix buggy testing process
Public Key should not support hard derivations.

see bip-0032 Implications

meherett and others added 30 commits May 27, 2021 09:10
Fix: Incorrect output of Base58 decoding.
add ZECTEST, fix LTC/LTCTEST

Changed -> Litecoin (LTC) mainnet extend private key from `0x019d9cfe` to `0x488ade4` and public key from `0x019da462` to `0x488b21e` prefixes.
Corrected the spec link for BIP141.
meherett and others added 27 commits October 24, 2021 09:20
Fix: missing quote in language error
`Public Key` should not support hard derivations.

see [bip-0032 Implications](https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki#implications)
@chenluyong
Copy link
Author

The derivation process has been verified by iancoleman

can be testing.

BIP39 Mnemonic
avocado harsh input rack like desert mask nominee left atom original tower shy barely base

Account Extended Public Key
xpub6CnRmcvtuVkmYV7UrPbrrhpJaor6iy5cFLQHdsgYQsfz9338T6Wqy3vHP1MXCEPMKzq1C8fErhrGnzEYarzsF814HnCzNF6vqo9JiGjjvE2

Address
16W7JeQXEzmYKX8UMFMrg6FwNSPduVdYHo

@chenluyong
Copy link
Author

Although they have the same path, the derived public key and private key are asymmetric, for example:

xprivate_key:m/44'/0'/0'/0/0
xpublic_key:m/44'/0'/0'/0/0

Due to the hardening derivation, the expected symmetric results cannot be obtained, even though they were initially symmetric.


Their paths are equal, and the public and private keys are also symmetric, for example:

xprivate_key:m/0/0
xpublic_key:m/0/0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants