Fix derivation from xpubs #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add testing section in readme
Fix: Incorrect output of Base58 decoding.
add ZECTEST, fix LTC/LTCTEST Changed -> Litecoin (LTC) mainnet extend private key from `0x019d9cfe` to `0x488ade4` and public key from `0x019da462` to `0x488b21e` prefixes.
Corrected the spec link for BIP141.
Fixed BIP141 link
Fixed links in readme
Added version info
This small patch fixes a check in order to allow arbitrary xpubs to be derived from without the need for root xpub/xprvs.
- New entries in cryptocurrencies.py;
- New {public,private}_key_base58check fields.
|
Hi Man, 👍👍 30330b8 I can't merge it now b/c it has git conflicts so I will merge it in the coming weeks. Great work. |
|
Hello @alecov, Can you fix the conflict and create new pull request? |
|
Hi Meherett,
Sure thing, I'll take a look at that.
Thanks,
…On Mon, Feb 28, 2022 at 4:20 AM Meheret Tesfaye ***@***.***> wrote:
Hello @alecov <https://github.com/alecov>, Can you fix the conflict and
create new pull request?
—
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE5R4ZAIEEILX3TPIZHDMETU5MO5LANCNFSM5FUH4I7A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Aleksey Covacevice
+55 (11) 983 375 566 <+55-11-983-375-566>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @meherett. This is the patch we've been discussing. Please check to see if it fits.