Fix cattr in Python 3.9 #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #967 +/- ##
========================================
Coverage 67.55% 67.55%
========================================
Files 130 130
Lines 22246 22248 +2
========================================
+ Hits 15028 15030 +2
Misses 7218 7218
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
talmo
added a commit
that referenced
this pull request
Oct 10, 2022
* Fix printing of auto-selected GPU free memory (#955) * Fix printing of auto-selected GPU free memory * Fix printing in inference * Lint * Fix add suggestions when target is current video (#956) * Fix export cli arg parsing (#962) * Fix cattr in Python 3.9 (#967) * Remove structuring hook for forward reference and handle manually * Handle missing key * Add sample movies to docs (#992) * Add initial examples * Add clips for all datasets * Add quick example clip * Typo on instance count for flies13 Co-authored-by: Liezl Maree <[email protected]> Co-authored-by: sheridana <[email protected]>
roomrys
added a commit
that referenced
this pull request
Nov 11, 2022
Docs update (#993) * Fix printing of auto-selected GPU free memory (#955) * Fix printing of auto-selected GPU free memory * Fix printing in inference * Lint * Fix add suggestions when target is current video (#956) * Fix export cli arg parsing (#962) * Fix cattr in Python 3.9 (#967) * Remove structuring hook for forward reference and handle manually * Handle missing key * Add sample movies to docs (#992) * Add initial examples * Add clips for all datasets * Add quick example clip * Typo on instance count for flies13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cattrs seems to break in newer versions of Python when using forward references. This PR is a workaround so we can get M1 support working again.
Relevant:
Types of changes
Does this address any currently open issues?
[list open issues here]
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️