MV (0): Add multiview classes #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 96.21% 96.24% +0.02%
==========================================
Files 17 18 +1
Lines 2327 2423 +96
==========================================
+ Hits 2239 2332 +93
- Misses 88 91 +3 ☔ View full report in Codecov by Sentry. |
talmo
approved these changes
Nov 27, 2024
| if np.shape(value) != expected_shape: | ||
| raise ValueError( | ||
| f"{attribute.name} must be a {expected_type} of size {expected_shape}, " | ||
| f"but recieved shape: {np.shape(value)} and type: {type(value)} for " |
There was a problem hiding this comment.
Suggested change
| f"but recieved shape: {np.shape(value)} and type: {type(value)} for " | |
| f"but received shape: {np.shape(value)} and type: {type(value)} for " |
| video: `Video` object to remove from `RecordingSession`. | ||
|
|
||
| Raises: | ||
| ValueError: If `Video` is not in associated `RecordingSession`. |
There was a problem hiding this comment.
Suggested change
| ValueError: If `Video` is not in associated `RecordingSession`. | |
| ValueError: If `video` is not in associated `RecordingSession`. |
|
|
||
| Raises: | ||
| ValueError: If `Camera` is not in associated `CameraGroup`. | ||
| ValueError: If `Video` is not a `Video` object. |
There was a problem hiding this comment.
Suggested change
| ValueError: If `Video` is not a `Video` object. | |
| ValueError: If `video` is not a `Video` object. |
| camera: `Camera` object to associate with `Video`. | ||
|
|
||
| Raises: | ||
| ValueError: If `Camera` is not in associated `CameraGroup`. |
There was a problem hiding this comment.
Suggested change
| ValueError: If `Camera` is not in associated `CameraGroup`. | |
| ValueError: If `camera` is not in associated `CameraGroup`. |
| matrix: Intrinsic camera matrix of size (3, 3) and type float64. | ||
| dist: Radial-tangential distortion coefficients [k_1, k_2, p_1, p_2, k_3] of | ||
| size (5,) and type float64. | ||
| size: Image size of camera in pixels of size (2,) and type int. |
There was a problem hiding this comment.
Is this (height, width) or (width, height)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's time to integrate the multiview classes into sleap-io! This will be a collection of stacked PRs with this very first PR adding the
Cameraclass and the very last PR implementing serialization/deserialization of theRecordingSessionclass.