Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gcloud): support deploy-gke for first deploy to new cluster #149

Merged
merged 1 commit into from
May 24, 2024
Merged

fix(gcloud): support deploy-gke for first deploy to new cluster #149

merged 1 commit into from
May 24, 2024

Conversation

TheKevJames
Copy link
Member

@TheKevJames TheKevJames commented May 22, 2024 •
edited
Loading

Summary

Ensures we're allowed to deploy the first revision of a deployment to an empty
cluster.

Standard Checklist

  • My comments/docstrings/type hints are clear
  • I've written new tests or this change does not need them
  • I've tested this manually
  • The architecture diagrams have been updated, if need be
  • Any external changes/dependencies are linked and described
  • I've included any special rollback strategies above
  • Any relevant metrics/monitors/SLOs have been added or modified
  • I've notified all relevant stakeholders of the change
  • I've updated .github/CODEOWNERS, if relevant

@TheKevJames TheKevJames requested a review from a team as a code owner May 22, 2024 16:46
@TheKevJames TheKevJames requested review from cphoward, juanamari94 and mauroparis and removed request for a team May 22, 2024 16:46
@TheKevJames TheKevJames merged commit 9d71f97 into master May 24, 2024
13 checks passed
@TheKevJames TheKevJames deleted the kjames/support-first-deploys-to-new-clusters branch May 24, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santiagofdialpad santiagofdialpad santiagofdialpad approved these changes

@shaundialpad shaundialpad shaundialpad approved these changes

@cphoward cphoward Awaiting requested review from cphoward cphoward is a code owner automatically assigned from talkiq/engineering

@juanamari94 juanamari94 Awaiting requested review from juanamari94 juanamari94 is a code owner automatically assigned from talkiq/engineering

@mauroparis mauroparis Awaiting requested review from mauroparis mauroparis is a code owner automatically assigned from talkiq/engineering

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheKevJames @shaundialpad @santiagofdialpad