feat: Support vlan_id and vlan_operation_mode on the hyperv_network_swtch resource #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glin-s6
changed the title
|
Missed the doc generation step. I've added the generated docs to the PR. |
|
Any chance I can get a review on this? @taliesins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for setting the vlanID on hyperv network switches. There's 4 modes and I only added support for 2 of them as they are the only ones I need for my use case. The interface can be expanded to support the other 2 though in the future.
Fixes:
hyperv_network_switchcould never update because the Powershell command expects a String and not an Object[]Tested: