Skip to content
This repository has been archived by the owner on Sep 26, 2022. It is now read-only.

Get rid of OrderedDicts #310

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ritikramuka
Copy link

addressing the issue: #233

Changed OrderedDict to dict as in python ^3.7 dict are ordered by default

@sr-gi
Copy link
Member

sr-gi commented Feb 24, 2022

@ritikramuka there was some issues with circle-ci so i had to roll an update. Can you rebase master so ci tests are run again?

@ritikramuka
Copy link
Author

@sr-gi can you help me figure out where the test is failing!

@sr-gi
Copy link
Member

sr-gi commented Feb 25, 2022

Have you run the test locally?

Looks like you've replaced OrderedDict by dict but you have not updated the methods. Here's the traceback:

Traceback (most recent call last):
    File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner
      self.run()
    File "/usr/lib/python3.8/threading.py", line 870, in run
      self._target(*self._args, **self._kwargs)
    File "/home/circleci/project/teos/watcher.py", line 491, in do_watch
      self.locator_cache.update(block_hash, locator_txid_map)
    File "/home/circleci/project/teos/watcher.py", line 119, in update
      self.remove_oldest_block()
    File "/home/circleci/project/teos/watcher.py", line 130, in remove_oldest_block
      block_hash, locators = self.blocks.popitem(last=False)
  TypeError: popitem() takes no keyword arguments

@ritikramuka
Copy link
Author

@sr-gi I am not able to run any test locally... as having an issue setting up leveldb and plyvel

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants