feat: add test for Tair DB #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: daz-3ux <[email protected]>
| from alibabacloud_vpc20160428.client import Client as Vpc20160428Client | ||
|
|
||
|
|
||
| class Instance_info: |
There was a problem hiding this comment.
参考 google python 风格 ，例如类名为 InstanceInfo 而不是 Instance_info。
| pass | ||
|
|
||
|
|
||
| class AliyunRedisCompatibilityTester(CloudRedisCompatabilityTest): |
| instance_infos = Instance_info(instance_id=instance_id, region_id=region_id, vpc_id=vpc_id, vsw_id=vsw_id) | ||
| return instance_infos | ||
|
|
||
| def configure_redis_instance(self, instance_infos): |
There was a problem hiding this comment.
我们的流程应该是：
- create_vpc
- create_vsw
- create_ecs
- create_redis
- config_ecs_to_redis
- run_test_on_ecs
- fetch_test_result
- destory all resources
现在的流程是申请公网地址，这样行不通，例如 AWS 就不允许用户申请公网，而且你现在申请公网时候，将白名单配置了全开，也有漏洞风险。
| print("清理阿里云Redis实例成功") | ||
|
|
||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
这部分功能希望集成在 redis_compatibility_test --genhtml 的选项中。但是要优化下现有流程，例如解析完每个 DataBase 的 config ，都有一个 create runtest destory 的三个流程。只不过开源产品就是 docker 拉起来，但是云产品就要调用接口买。
There was a problem hiding this comment.
我打算先优化现有流程,把代码和流程写规范,最后再加入这个继承,继承的实现可以单独开一个PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.