Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(rdb): parse rdb use less memeory #764

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

vczyh
Copy link
Contributor

@vczyh vczyh commented Jan 26, 2024

相关讨论:#761

  • 使用 channel 传递 RedisCmd。
  • 修复了一个BUG: 不使用 restore 命令迁移 Stream 类型的时候,创建 consumer Group 应该使用 XGROUP CREATE,原来使用的是 CREATE 导致报错。

@CLAassistant
Copy link

CLAassistant commented Jan 26, 2024

CLA assistant check
All committers have signed the CLA.

@vczyh
Copy link
Contributor Author

vczyh commented Jan 26, 2024

workflow 失败了,不知道为什么:

[2024-01-26 07:57:14.008] 11511:M 26 Jan 07:57:08.982 # Creating Server TCP listening socket *:48024: bind: Address already in use

@suxb201
Copy link
Member

suxb201 commented Jan 26, 2024

workflow 失败了,不知道为什么:

[2024-01-26 07:57:14.008] 11511:M 26 Jan 07:57:08.982 # Creating Server TCP listening socket *:48024: bind: Address already in use

已知 CI 的 bug,稍后重试。

@vczyh
Copy link
Contributor Author

vczyh commented Jan 26, 2024

下一个又失败了,不知道是不是我的问题:

[2024-01-26 08:09:32.250] Assert Failed: expect [b'string', b'0', b'-1', b'123456789'], but is [None, None, None, None]

@vczyh
Copy link
Contributor Author

vczyh commented Jan 29, 2024

@suxb201 大佬给看看,我怕年后忘了这事情~

@suxb201
Copy link
Member

suxb201 commented Jan 29, 2024

@vczyh 我晚上看下,看代码没什么问题。

@vczyh
Copy link
Contributor Author

vczyh commented Jan 29, 2024

@vczyh 我晚上看下,看代码没什么问题。

好的~

@suxb201
Copy link
Member

suxb201 commented Jan 29, 2024

怀疑原先 Tair 结构的解析存在问题,之前测试没测到,现在每次 rewrite 测到了。我后续确认下。

@vczyh
Copy link
Contributor Author

vczyh commented Jan 29, 2024

有可能,辛苦了

@suxb201 suxb201 merged commit 9527b04 into tair-opensource:v4 Feb 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants