Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cluster_helper.metrics_port zero means metric disable #648

Closed
wants to merge 3 commits into from

Conversation

ElvisWai
Copy link
Contributor

  • metrics_port 为0,监控不开启
  • pprof_port 若不为0,将不会自增,出现抢占端口的问题
  • 修复loop函数在metrics_port为0时报错,影响:监控不开启时,主进程无法通过日志确定当前同步进度

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@suxb201
Copy link
Member

suxb201 commented Sep 27, 2023

v3 版本不演进了,我暂时关掉这个 PR

@suxb201 suxb201 closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics_port = 0 仍然会开启端口
3 participants