Fix scanning classes delimited by tab characters #15169
Open
+282
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
fix/issue-15148
branch
2 times, most recently
from
2a4c256
to
e6b4458
Compare
RobinMalfait
commented
Nov 25, 2024
| 'test-green', | ||
| 'test-blue', | ||
| 'test-tomato', | ||
| 'multiple-entries-to-keep-newlines', |
There was a problem hiding this comment.
My prettier hack is I use an empty // comment to do this
There was a problem hiding this comment.
(but this is fine too)
There was a problem hiding this comment.
That introduced a space, so didn't trust it 😂
RobinMalfait
force-pushed
the
fix/issue-15148
branch
from
1a3a8e8
to
fab794a
Compare
RobinMalfait
changed the title
RobinMalfait
force-pushed
the
fix/issue-15148
branch
from
fab794a
to
0e5eb84
Compare
|
Should there be explicit tests for tabs vs. sort of sneaking it into the multi-line arrays test? |
We were only looking at spaces, but we should look at newlines, tabs, ... as well.
RobinMalfait
force-pushed
the
fix/issue-15148
branch
from
0e5eb84
to
48f68b7
Compare
|
@adamwathan good call, I added dedicated whitespace related tests (none, spaces, tabs, and newlines) in the Rust tests. Also add an integration test for the CLI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where multi-line candidates in Svelte files couldn't be found as reported in #15148
After digging in, the real culprit seems to be that the reproduction used tab
\tcharacters instead of spaces and we only delimited explicitly on spaces.Initially I couldn't reproduce this in an integration test until we (@thecrypticace and I) realised that
\twas being used.Test plan:
This PR adds an integration test that fails before the fix happens. The fix itself is easy in the sense that we just use all ascii whitespace characters instead of just spaces.
Fixes: #15148