-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show navigation and zoom utilities in resources explorer #1070 #1145
Merged
mlabouardy
merged 9 commits into
tailwarden:develop
from
faisal7008:feature/1070-explorer-zoom-drag
Nov 2, 2023
Merged
feat: show navigation and zoom utilities in resources explorer #1070 #1145
mlabouardy
merged 9 commits into
tailwarden:develop
from
faisal7008:feature/1070-explorer-zoom-drag
Nov 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faisal7008
requested review from
mlabouardy,
ShubhamPalriwala,
AvineshTripathi,
greghub and
Traxmaxx
as code owners
October 27, 2023 19:24
Traxmaxx
reviewed
Oct 30, 2023
Traxmaxx
approved these changes
Nov 1, 2023
Kolawole99
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation of the DependencyGraph component in the Komiser dashboard lacks a feature to show the current zoom level and temporarily disable node dragging.
fixes #1070
Solution
I have implemented a zoom input that allows users to either zoom in, zoom out, or manually enter a zoom value. Additionally, I have added functionality that enables or disables the dragging of nodes.
Changes Made
How to Test
Screenshots
komiser.zoom.utility.1070.compressed.mp4
check out the video
Notes
[Any additional notes or information that you would like to share with the reviewers.]
Checklist
Reviewers
@AllieMendes