Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate to runtime config #3229

Merged
merged 4 commits into from
Dec 26, 2024
Merged

test: migrate to runtime config #3229

merged 4 commits into from
Dec 26, 2024

Conversation

meskill
Copy link
Contributor

@meskill meskill commented Dec 24, 2024

Summary:
Migrate execution_spec tests to runtime config instead of graphql configuration only.

Please, note that most of the snapshots are changed only in the way of adding new link that now represents graphql schema and the behaviour is not changed.-

Issue Reference(s):
Related to #3164

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.30%. Comparing base (52d515c) to head (22c82f8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3229      +/-   ##
==========================================
- Coverage   86.44%   86.30%   -0.14%     
==========================================
  Files         282      282              
  Lines       28756    28761       +5     
==========================================
- Hits        24858    24823      -35     
- Misses       3898     3938      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath enabled auto-merge (squash) December 26, 2024 08:48
@tusharmath tusharmath merged commit 4cf48a1 into main Dec 26, 2024
32 of 33 checks passed
@tusharmath tusharmath deleted the test/runtime-config branch December 26, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants