-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dedupe dedupe settings #2183
fix: dedupe dedupe settings #2183
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2183 +/- ##
==========================================
- Coverage 84.12% 84.12% -0.01%
==========================================
Files 212 212
Lines 20054 20032 -22
==========================================
- Hits 16870 16851 -19
+ Misses 3184 3181 -3 ☔ View full report in Codecov by Sentry. |
Thanks for fixing the lint issues, I didn't expect the warning will cause the lint to fail in CI. One more thing I wanted to quickly get your opinion on this line Line 74 in 4890980
The above if - else block is probably not needed because this block will get executed only if this check here didn't pass Line 69 in 4890980
so I guess we can get rid of the if at line 74 completely right ? The tests are still working on my machine if I removed that check. |
That would be right. |
Head branch was pushed to by a user without write access
I made a commit that removes the unnecessary check thanks. |
@bnchi Can you please update the documentation for these changes here - https://github.com/tailcallhq/tailcallhq.github.io |
Summary:
Issue Reference(s):
Fixes #2182
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>