Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stack]: rewrite GraphQL engine - 0 #2090

Closed
wants to merge 63 commits into from
Closed

[stack]: rewrite GraphQL engine - 0 #2090

wants to merge 63 commits into from

Conversation

tusharmath
Copy link
Contributor

@tusharmath tusharmath commented Jun 2, 2024

TODO


ExecutionDocument to QueryPlan

@tusharmath tusharmath changed the title Query JIT feat: Query JIT Jun 3, 2024
@tusharmath tusharmath changed the title feat: Query JIT feat: graphQL engine re-write Jun 3, 2024
@tusharmath tusharmath marked this pull request as ready for review June 3, 2024 14:48
@tusharmath tusharmath marked this pull request as draft June 3, 2024 14:48
@tusharmath tusharmath added this to the GraphQL Engine v2 milestone Jun 3, 2024
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 82.27593% with 176 lines in your changes missing coverage. Please review.

Project coverage is 84.12%. Comparing base (ab0b519) to head (a8b5e49).
Report is 12 commits behind head on main.

Files Patch % Lines
src/core/ir/jit/helper.rs 44.37% 84 Missing ⚠️
src/core/ir/jit/blueprint_index.rs 65.59% 32 Missing ⚠️
src/core/ir/jit/synth.rs 91.07% 24 Missing ⚠️
src/core/ir/jit/context.rs 83.09% 12 Missing ⚠️
src/core/ir/jit/model.rs 91.35% 7 Missing ⚠️
src/core/counter.rs 37.50% 5 Missing ⚠️
src/core/ir/jit/builder.rs 98.17% 4 Missing ⚠️
src/core/ir/jit/execute.rs 93.10% 4 Missing ⚠️
src/core/ir/mod.rs 40.00% 3 Missing ⚠️
src/core/blueprint/blueprint.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2090      +/-   ##
==========================================
- Coverage   84.18%   84.12%   -0.07%     
==========================================
  Files         212      220       +8     
  Lines       20097    21060     +963     
==========================================
+ Hits        16919    17716     +797     
- Misses       3178     3344     +166     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath marked this pull request as ready for review June 4, 2024 07:40
@tusharmath tusharmath marked this pull request as draft June 4, 2024 08:10
@amitksingh1490 amitksingh1490 removed the ci: benchmark Runs benchmarks label Jun 10, 2024
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 12, 2024
@ssddOnTop ssddOnTop removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 12, 2024
This was referenced Jun 12, 2024
@tusharmath tusharmath changed the title feat: graphQL engine re-write [stack]: rewrite GraphQL engine - 0 Jun 14, 2024
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 17, 2024
@tusharmath tusharmath closed this Jun 22, 2024
@ssddOnTop ssddOnTop deleted the query-jit-4 branch July 29, 2024 06:26
@ssddOnTop ssddOnTop restored the query-jit-4 branch July 29, 2024 06:26
@ssddOnTop ssddOnTop deleted the query-jit-4 branch October 30, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants