Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input types loose out on provided graphQL documentation #2015

Merged
merged 9 commits into from
May 31, 2024

Conversation

emekaokoli19
Copy link
Contributor

@emekaokoli19 emekaokoli19 commented May 24, 2024

Summary:
Add descriptions to input object types.

Issue Reference(s):
Fixes #1625

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

/claim #1625

@github-actions github-actions bot added type: docs Related to documentation and information. type: fix Iterations on existing features or infrastructure. labels May 24, 2024
@emekaokoli19
Copy link
Contributor Author

@tusharmath I traced through the codebase and found the problem, I also fixed the field documentation on input objects.

@tusharmath tusharmath marked this pull request as draft May 24, 2024 06:32
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (f56f55d) to head (d60d222).

Current head d60d222 differs from pull request most recent head c2e37d0

Please upload reports for the commit c2e37d0 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2015      +/-   ##
==========================================
- Coverage   82.70%   82.62%   -0.09%     
==========================================
  Files         178      174       -4     
  Lines       18039    17952      -87     
==========================================
- Hits        14920    14833      -87     
  Misses       3119     3119              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emekaokoli19 emekaokoli19 marked this pull request as ready for review May 25, 2024 22:21
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels May 29, 2024
@tusharmath tusharmath enabled auto-merge (squash) May 29, 2024 15:29
@tusharmath tusharmath removed the type: docs Related to documentation and information. label May 29, 2024
@github-actions github-actions bot added the type: docs Related to documentation and information. label May 29, 2024
auto-merge was automatically disabled May 30, 2024 12:25

Pull request was closed

@emekaokoli19 emekaokoli19 reopened this May 30, 2024
@tusharmath tusharmath enabled auto-merge (squash) May 31, 2024 08:35
@tusharmath
Copy link
Contributor

Wired, why did this not get merged?

@tusharmath tusharmath removed the type: docs Related to documentation and information. label May 31, 2024
@tusharmath tusharmath disabled auto-merge May 31, 2024 09:41
@tusharmath tusharmath merged commit 27ea39a into tailcallhq:main May 31, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(config): input types loose out on provided graphQL documentation
2 participants