Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added push WRK output into the bencher #2001

Closed
wants to merge 8 commits into from
Closed

chore: added push WRK output into the bencher #2001

wants to merge 8 commits into from

Conversation

varshith257
Copy link
Contributor

@varshith257 varshith257 commented May 21, 2024 •
edited
Loading

Summary:

  1. I have modified the GitHub Actions workflow to include steps for running WRK, generating the BMF JSON using the Python script, and uploading the results to bencher.dev using the bencherdev/bencher@main action.
  2. Introduced a Python scriptgenerate_bmf_json.pythat converts WRK output into Bencher Metric Format (BMF) JSON. This script reads wrk_output.txt, extracts necessary metrics and formats them into BMF JSON.

Issue Reference(s):
/fixes #1993
/claim #1993

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@algora-pbc algora-pbc bot mentioned this pull request May 21, 2024
Closed
@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label May 21, 2024
@varshith257 varshith257 changed the title chore: added push WRK output into the bencher fix added push WRK output into the bencher May 21, 2024
@varshith257 varshith257 changed the title fix added push WRK output into the bencher chore: added push WRK output into the bencher May 21, 2024
varshith257
varshith257 commented May 21, 2024
View reviewed changes
Copy link
Contributor Author

@varshith257 varshith257 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

      - id: convert_wrk_output_markdown
        name: Convert Output to Markdown
        working-directory: ci-benchmark
        run: |
          node wrk-output-to-md.js wrk-output.txt > body.md
      - id: cat_md
        name: Cat Markdown
        working-directory: ci-benchmark
        run: |
          cat body.md
      - name: "Upload Artifact"
        uses: actions/upload-artifact@v4
        with:
          name: body
          path: ci-benchmark/body.md

Can this steps can be removed?

@varshith257
Copy link
Contributor Author

When I run ./lint.sh mode=fix the paths are changing of docs/** -> docs/

@varshith257
Copy link
Contributor Author

@tusharmath Can I get reviewed this PR?

@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 25, 2024
@varshith257
Copy link
Contributor Author

Waiting for review

@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 25, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 27, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 27, 2024
tusharmath
tusharmath requested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@tusharmath tusharmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stick to node.js and rust only in this PR. Adding python to the mix isn't worth it.

ci-benchmark/generate_bmf_json.py
return bmf_json
# Example usage
wrk_data = parse_wrk_output('wrk_output.txt')
bmf_data = generate_bmf_json(wrk_data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try this

https://gist.github.com/tejaskokje/66738c844920e996189168abc52fa1ee

@tusharmath tusharmath marked this pull request as draft May 29, 2024 15:34
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels May 31, 2024
@tusharmath
Copy link
Contributor

Fixed in #2080

@tusharmath tusharmath closed this Jun 1, 2024
@varshith257 varshith257 deleted the fix-bencher branch July 6, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmath tusharmath tusharmath requested changes

Assignees
No one assigned
Labels
🙋 Bounty claim type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: push WRK output into the bencher
2 participants
@varshith257 @tusharmath