chore: add integration tests for CORS #1989

varshith257 · 2024-05-20T08:03:15Z

Summary:

The set_common_headers function has been created to handle common header settings to remove code duplication patterns.
Added Integration tests for CORS .

Issue Reference(s):

Fixes chore: add tests for Tailcall CORS #1984

Build & Testing:

I ran cargo test successfully.
I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

I have added relevant unit & integration tests.
I have updated the documentation accordingly.
I have performed a self-review of my code.
PR follows the naming convention of <type>(<optional scope>): <title>

varshith257 · 2024-05-20T08:13:24Z

@tusharmath I think it's ready for your review. If any suggestions or modifications needed, I am ready to incorporate them

tests/core/cors.rs

github-actions · 2024-05-25T08:02:48Z

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

varshith257 · 2024-05-25T10:28:33Z

Will update the tests as required soon

github-actions · 2024-05-27T14:02:42Z

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

github-actions · 2024-05-29T16:03:17Z

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

github-actions · 2024-05-31T18:03:04Z

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

github-actions · 2024-06-06T15:02:56Z

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

tusharmath · 2024-06-11T10:48:45Z

src/core/http/request_handler.rs

+    req_ctx: &RequestContext,
+    app_ctx: &AppContext,
+) {
+    set_common_headers(resp.headers_mut(), app_ctx, req_ctx);
 }


These changes doesn't seem to be doing much. Can we revert it to the one it was in main?

Okay! @tusharmath.

varshith257 · 2024-06-11T12:19:16Z

@tusharmath Any tip would be great for my efforts of trying to get optimise the request_handler.rs file from a long ? and thanks for guiding to make contributions to tailcall

tests/execution/test-cors-tailcall-run.md

tusharmath

Fix review comments. Whenever completed, please mark it as ready to review.

varshith257 · 2024-06-12T12:48:06Z

@tusharmath I have added some more tests. PTAL

codecov · 2024-06-12T12:48:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.15%. Comparing base (c1dd7c7) to head (c205d4a).

❗ Current head c205d4a differs from pull request most recent head 40f5e90

Please upload reports for the commit 40f5e90 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1989      +/-   ##
==========================================
- Coverage   85.91%   84.15%   -1.76%     
==========================================
  Files         211      212       +1     
  Lines       19993    19987       -6     
==========================================
- Hits        17177    16821     -356     
- Misses       2816     3166     +350

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

varshith257 · 2024-06-12T12:50:26Z

I am unable to run cargo test to generate snapshots. This emitting lot of errors

github-actions · 2024-06-17T11:02:49Z

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

meskill · 2024-06-21T10:29:56Z

tests/execution/test-cors-tailcall-run.md

+  @server(
+    port: 8000
+    headers: {
+      cors: {allowHeaders: ["*"], allowMethods: ["GET", "POST", "OPTIONS"], allowOrigins: ["https://tailcall.run"]}


The issue is intended to test headers that put automatically for tailcall.run and therefore we don't need to specify headers in test - we need to test that it works without headers

meskill · 2024-06-21T10:30:40Z

tests/execution/test-cors-tailcall-run.md

+}
+
+type Query {
+  example: String @http(path: "/example")


need to mock this request

meskill · 2024-06-21T10:31:34Z

tests/execution/test-cors-tailcall-run.md

+  expected:
+    status: 200
+    headers:
+      access-control-allow-origin: https://tailcall.run


we use snapshots and not explicit expected definitions in tests. That should be removed and proper snapshots should be generated

meskill · 2024-06-21T10:33:07Z

Closing for now since it requires additional work. Feel free to reopen this when it's ready. If you have any troubles with code/tooling please ask in our #contributors channel on Discord

varshith257 and others added 4 commits May 20, 2024 13:28

modified request_handler.rs

451bf10

added cors integration tests

d5527c7

Merge branch 'main' of https://github.com/varshith257/tailcall

b8eae8b

Merge branch 'tailcallhq:main' into main

abbb30c

github-actions bot added the type: fix Iterations on existing features or infrastructure. label May 20, 2024

varshith257 changed the title ~~fix: enchance request_handler.rs and added cors integration tests~~ fix: enchanced request_handler.rs and added cors integration tests May 20, 2024

Merge branch 'main' into main

3b69bce

tusharmath reviewed May 22, 2024

View reviewed changes

tests/core/cors.rs Outdated Show resolved Hide resolved

Merge branch 'main' into main

bf886b2

tusharmath marked this pull request as draft May 23, 2024 07:32

github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 25, 2024

Merge branch 'main' into main

339612b

github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 25, 2024

github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels May 27, 2024

Merge branch 'main' into main

e66bac7

github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels May 29, 2024

github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 31, 2024

Merge branch 'main' into main

1b66d13

github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 4, 2024

github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Jun 6, 2024

tusharmath changed the title ~~fix: enchanced request_handler.rs and added cors integration tests~~ chore: add integration tests for CORS Jun 11, 2024

tusharmath reviewed Jun 11, 2024

View reviewed changes

revert changes request_handler.rs

c205d4a

github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Jun 11, 2024

varshith257 requested a review from tusharmath June 11, 2024 12:18

tusharmath approved these changes Jun 12, 2024

View reviewed changes

tusharmath enabled auto-merge (squash) June 12, 2024 05:46

tusharmath reviewed Jun 12, 2024

View reviewed changes

tests/execution/test-cors-tailcall-run.md Show resolved Hide resolved

tusharmath reviewed Jun 12, 2024

View reviewed changes

tests/execution/test-cors-tailcall-run.md Show resolved Hide resolved

tusharmath requested changes Jun 12, 2024

View reviewed changes

tusharmath marked this pull request as draft June 12, 2024 05:48

auto-merge was automatically disabled June 12, 2024 05:48
Pull request was converted to draft

varshith257 added 2 commits June 12, 2024 16:58

Update test-cors-tailcall-run.md

2a5531a

Merge branch 'main' into main

c483d8b

varshith257 marked this pull request as ready for review June 12, 2024 12:47

varshith257 requested a review from tusharmath June 12, 2024 12:50

varshith257 added 3 commits June 13, 2024 11:05

Merge branch 'main' into main

34fd3d0

Merge branch 'main' into main

28871b6

Merge branch 'main' into main

6536387

github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 17, 2024

Merge branch 'main' into main

40f5e90

github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 19, 2024

meskill requested changes Jun 21, 2024

View reviewed changes

meskill closed this Jun 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add integration tests for CORS #1989

chore: add integration tests for CORS #1989

varshith257 commented May 20, 2024 •

edited by meskill

Loading

varshith257 commented May 20, 2024

github-actions bot commented May 25, 2024

varshith257 commented May 25, 2024

github-actions bot commented May 27, 2024

github-actions bot commented May 29, 2024

github-actions bot commented May 31, 2024

github-actions bot commented Jun 6, 2024

tusharmath Jun 11, 2024

varshith257 Jun 11, 2024 •

edited

Loading

varshith257 commented Jun 11, 2024 •

edited

Loading

tusharmath left a comment •

edited

Loading

varshith257 commented Jun 12, 2024

codecov bot commented Jun 12, 2024 •

edited

Loading

varshith257 commented Jun 12, 2024

github-actions bot commented Jun 17, 2024

meskill Jun 21, 2024

meskill Jun 21, 2024

meskill Jun 21, 2024

meskill commented Jun 21, 2024

chore: add integration tests for CORS #1989

chore: add integration tests for CORS #1989

Conversation

varshith257 commented May 20, 2024 • edited by meskill Loading

varshith257 commented May 20, 2024

github-actions bot commented May 25, 2024

varshith257 commented May 25, 2024

github-actions bot commented May 27, 2024

github-actions bot commented May 29, 2024

github-actions bot commented May 31, 2024

github-actions bot commented Jun 6, 2024

tusharmath Jun 11, 2024

Choose a reason for hiding this comment

varshith257 Jun 11, 2024 • edited Loading

Choose a reason for hiding this comment

varshith257 commented Jun 11, 2024 • edited Loading

tusharmath left a comment • edited Loading

Choose a reason for hiding this comment

varshith257 commented Jun 12, 2024

codecov bot commented Jun 12, 2024 • edited Loading

Codecov Report

varshith257 commented Jun 12, 2024

github-actions bot commented Jun 17, 2024

meskill Jun 21, 2024

Choose a reason for hiding this comment

meskill Jun 21, 2024

Choose a reason for hiding this comment

meskill Jun 21, 2024

Choose a reason for hiding this comment

meskill commented Jun 21, 2024

varshith257 commented May 20, 2024 •

edited by meskill

Loading

varshith257 Jun 11, 2024 •

edited

Loading

varshith257 commented Jun 11, 2024 •

edited

Loading

tusharmath left a comment •

edited

Loading

codecov bot commented Jun 12, 2024 •

edited

Loading