Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wasm): support for NPM and Browser #1908

Merged
merged 42 commits into from
Jul 28, 2024
Merged

feat(wasm): support for NPM and Browser #1908

merged 42 commits into from
Jul 28, 2024

Conversation

ssddOnTop
Copy link
Member

@ssddOnTop ssddOnTop commented May 9, 2024 •
edited
Loading

Issue Reference(s):
Fixes #1038
/claim 1038

TODO

  • add tests
  • fix logging
  • fix cache

@algora-pbc algora-pbc bot mentioned this pull request May 9, 2024
Closed
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label May 9, 2024
@ssddOnTop ssddOnTop marked this pull request as ready for review May 10, 2024 07:58
@codecov Codecov
Copy link

codecov bot commented May 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 6.74157% with 166 lines in your changes missing coverage. Please review.

Project coverage is 86.75%. Comparing base (384ebf2) to head (4aa8665).

Files Patch % Lines
tailcall-wasm/src/builder.rs 0.00% 59 Missing ⚠️
tailcall-wasm/src/lib.rs 0.00% 33 Missing ⚠️
tailcall-wasm/src/runtime.rs 0.00% 29 Missing ⚠️
tailcall-wasm/src/http.rs 0.00% 24 Missing ⚠️
tailcall-wasm/src/env.rs 0.00% 9 Missing ⚠️
tailcall-wasm/src/file.rs 0.00% 9 Missing ⚠️
src/core/cache.rs 80.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1908      +/-   ##
==========================================
- Coverage   87.34%   86.75%   -0.60%     
==========================================
  Files         239      245       +6     
  Lines       23827    24001     +174     
==========================================
+ Hits        20811    20821      +10     
- Misses       3016     3180     +164

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels May 13, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels May 15, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 17, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 11, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Jun 14, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 16, 2024
@github-actions GitHub Actions
Copy link

PR closed after 5 days of inactivity.

@github-actions github-actions bot closed this Jun 21, 2024
@ssddOnTop ssddOnTop deleted the feat/tailcall-web branch July 23, 2024 05:51
@ssddOnTop ssddOnTop restored the feat/tailcall-web branch July 23, 2024 05:52
@ssddOnTop ssddOnTop reopened this Jul 23, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jul 23, 2024
@tusharmath tusharmath marked this pull request as draft July 27, 2024 07:26
@tusharmath
Copy link
Contributor

Unable to run Tailcall via the browser.

Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention.

@ssddOnTop ssddOnTop marked this pull request as ready for review July 27, 2024 09:39
@ssddOnTop
Copy link
Member Author

Unable to run Tailcall via the browser.

Updated docs..

after running python server, you need to pass a query ?config=<>
example:

http://0.0.0.0:8000/example/browser/?config=https://raw.githubusercontent.com/tailcallhq/tailcall/main/examples/jsonplaceholder.graphql

@tusharmath tusharmath enabled auto-merge (squash) July 28, 2024 08:12
@tusharmath tusharmath merged commit 9d817d8 into main Jul 28, 2024
34 of 36 checks passed
@tusharmath tusharmath deleted the feat/tailcall-web branch July 28, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmath tusharmath tusharmath approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: publish tailcall WASM build on NPM
2 participants
@ssddOnTop @tusharmath