perf: creating request in cache_key #1823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1823 +/- ##
=======================================
Coverage 86.89% 86.89%
=======================================
Files 156 156
Lines 15829 15839 +10
=======================================
+ Hits 13755 13764 +9
- Misses 2074 2075 +1 ☔ View full report in Codecov by Sentry. |
|
| Report | Wed, May 1, 2024 at 13:26:53 UTC |
| Project | tailcall |
| Branch | 1823/merge |
| Testbed | benchmarking-runner |
🚨 1 ALERT: Threshold Boundary Limit exceeded!
| Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
|---|---|---|---|---|---|
| group_by | Latency (nanoseconds (ns)) | 🚨 (view plot | view alert) | 647.92 (+6.25%) | 637.84 (101.58%) |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| group_by | 🚨 (view plot | view alert) | 647.92 (+6.25%) | 637.84 (101.58%) |
| input/args.missing | ✅ (view plot) | 25.02 (-1.24%) | 26.22 (95.39%) |
| input/args.nested.existing | ✅ (view plot) | 56.27 (+0.09%) | 58.26 (96.57%) |
| input/args.nested.missing | ✅ (view plot) | 38.97 (-0.35%) | 39.97 (97.51%) |
| input/args.root | ✅ (view plot) | 52.94 (+0.26%) | 54.58 (96.99%) |
| input/headers.existing | ✅ (view plot) | 31.43 (-0.31%) | 31.81 (98.81%) |
| input/headers.missing | ✅ (view plot) | 30.07 (-1.31%) | 31.23 (96.28%) |
| input/value.missing | ✅ (view plot) | 23.08 (-2.27%) | 25.07 (92.07%) |
| input/value.nested.existing | ✅ (view plot) | 39.65 (-3.30%) | 42.78 (92.68%) |
| input/value.nested.missing | ✅ (view plot) | 34.97 (-2.17%) | 37.35 (93.64%) |
| input/value.root | ✅ (view plot) | 39.05 (+1.08%) | 39.86 (97.95%) |
| input/vars.existing | ✅ (view plot) | 8.38 (-0.92%) | 8.87 (94.45%) |
| input/vars.missing | ✅ (view plot) | 8.67 (+6.44%) | 8.98 (96.54%) |
| test_batched_body | ✅ (view plot) | 1,756,100.00 (+1.50%) | 1,808,647.61 (97.09%) |
| test_data_loader | ✅ (view plot) | 468,510.00 (-0.80%) | 489,876.78 (95.64%) |
| with_mustache_expressions | ✅ (view plot) | 1,135.00 (-2.48%) | 1,216.43 (93.31%) |
| with_mustache_literal | ✅ (view plot) | 710.66 (-1.73%) | 759.56 (93.56%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
the
state: inactive
|
PR closed after 5 days of inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Creating request in the call to
cache_keyand reusing it inevalBuild & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>