Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement JAQ #1752

Closed
wants to merge 4 commits into from
Closed

feat: implement JAQ #1752

wants to merge 4 commits into from

Conversation

ssddOnTop
Copy link
Member

Issue Reference(s):
Fixes #1321

@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Apr 18, 2024
ssddOnTop
ssddOnTop commented Apr 18, 2024
View reviewed changes
assets/logging.png Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk why's this happening

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check your Git settings.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same issue to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it shows changes without any modifications actually.

ssddOnTop
ssddOnTop commented Apr 18, 2024
View reviewed changes
src/json/json_like.rs Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Apr 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.29630% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.89%. Comparing base (a6cea61) to head (5d7cf2b).
Report is 19 commits behind head on main.

Files Patch % Lines
src/blueprint/dynamic_value.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1752   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files         155      155           
  Lines       15600    15623   +23     
=======================================
+ Hits        13555    13575   +20     
- Misses       2045     2048    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssddOnTop ssddOnTop added the ci: benchmark Runs benchmarks label Apr 20, 2024
@ssddOnTop
Copy link
Member Author

performance is a BIG question now

@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Apr 22, 2024
@ssddOnTop ssddOnTop removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Apr 22, 2024
@tusharmath
Copy link
Contributor

@amitksingh1490 are you working on this?

@amitksingh1490
Copy link
Collaborator

Yes

@ssddOnTop
Copy link
Member Author

I am here to help..

Maybe just drop comments Ill fix

tusharmath
tusharmath reviewed Apr 23, 2024
View reviewed changes
src/json/json_like.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Apr 27, 2024
@ssddOnTop
Copy link
Member Author

closing in favor of #1801

@ssddOnTop ssddOnTop closed this Apr 27, 2024
@ssddOnTop ssddOnTop deleted the feat/jq-support branch April 27, 2024 06:28
@ssddOnTop ssddOnTop restored the feat/jq-support branch May 4, 2024 15:18
@ssddOnTop ssddOnTop deleted the feat/jq-support branch May 4, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webbdays webbdays webbdays left review comments

@tusharmath tusharmath tusharmath left review comments

Assignees
No one assigned
Labels
ci: benchmark Runs benchmarks state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using JAQ as an alternative to mustache templates
4 participants
@ssddOnTop @tusharmath @amitksingh1490 @webbdays