Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): replace deno_core with rquickjs #1713

Merged
merged 15 commits into from
May 4, 2024
+790 −570
Merged

fix(js): replace deno_core with rquickjs #1713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
346bcfe
feat(js): replace deno_core with rquickjs
mayant15 Apr 12, 2024
26ccedd
feat(js): add print builtin to quickjs runtime
mayant15 Apr 12, 2024
52216d0
feat(js): serde for request/response
mayant15 Apr 14, 2024
2adeab5
chore: lint autofix
mayant15 Apr 16, 2024
0134a9e
chore: remove unwraps and better logs
mayant15 Apr 16, 2024
0100010
test(js): add quickjs conversion tests
mayant15 Apr 17, 2024
03079d0
chore: lint
mayant15 Apr 17, 2024
ba8a21a
chore: lint
mayant15 Apr 17, 2024
bb936e8
refactor: dont save a ref to js runtime
mayant15 Apr 25, 2024
99acd51
chore: fmt
amitksingh1490 May 4, 2024
935d623
refactor: use JSRequest
amitksingh1490 May 4, 2024
aec398d
refactor: JsResponse
amitksingh1490 May 4, 2024
be31865
refactor: JsResponse
amitksingh1490 May 4, 2024
1b5c683
update js_request
tusharmath May 4, 2024
0b71b9f
lint fixes
tusharmath May 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
594 changes: 236 additions & 358 deletions Cargo.lock
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 3 additions & 5 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,7 @@ lazy_static = "1.4.0"
which = { version = "6.0.1", optional = true }
async-recursion = "1.1.1"
tempfile = "3.10.1"
deno_core = { version = "0.278.0", optional = true, features = [
"v8_use_custom_libcxx",
], default-features = false }
rquickjs = { "version" = "0.5.1", optional = true, features = ["full"] }
strum_macros = "0.26.2"
# TODO: disable some levels with features?
tracing = "0.1.40"
Expand Down Expand Up @@ -167,7 +165,7 @@ tailcall-fixtures = { path = "./tailcall-fixtures" }

# Feature Flag to enable V8.
# V8 currently is not support on all platforms so, we control it via this feature flag.
js = ["dep:deno_core"]
js = ["dep:rquickjs"]

# Feature Flag to core CLI features.
# This is created to control what we expose for WASM.
Expand Down Expand Up @@ -233,4 +231,4 @@ harness = false

[[test]]
name = "execution_spec"
harness = false
harness = false
Loading
Loading