Skip to content

Commit

Permalink
chore: upgrade opentelemetry version (#2049)
Browse files Browse the repository at this point in the history
  • Loading branch information
meskill authored May 30, 2024
1 parent 36105ec commit 871c0b9
Show file tree
Hide file tree
Showing 4 changed files with 108 additions and 61 deletions.
134 changes: 92 additions & 42 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,14 @@ rustls = { version = "0.23.5", optional = true, features = [
], default-features = false }
rustls-pki-types = "1.5.0"
inquire = { version = "0.7.5", optional = true }
opentelemetry-otlp = { version = "0.15.0", features = [
opentelemetry-otlp = { version = "0.16.0", features = [
"trace",
"logs",
"metrics",
# required to make grpc requests
"tls-roots",
], optional = true }
opentelemetry-system-metrics = { version = "0.1.8", optional = true }
opentelemetry-system-metrics = { version = "0.1.9", optional = true }
tailcall-http-cache = { path = "tailcall-http-cache", optional = true }
tailcall-version = { path = "./tailcall-version", optional = true }

Expand Down Expand Up @@ -114,25 +114,25 @@ tracing-subscriber = { version = "0.3.18", features = [
"fmt",
"env-filter",
] }
tracing-opentelemetry = "0.23.0"
tracing-opentelemetry = "0.24.0"
getrandom = { version = "0.2.14", features = ["js"] }
prometheus = "0.13.4"
tonic = { version = "0.11.0", default-features = false }
opentelemetry-semantic-conventions = "0.14.0"
opentelemetry = { version = "0.22.0", features = ["trace", "logs", "metrics"] }
opentelemetry_sdk = { version = "0.22.1", features = [
opentelemetry-semantic-conventions = "0.15.0"
opentelemetry = { version = "0.23.0", features = ["trace", "logs", "metrics"] }
opentelemetry_sdk = { version = "0.23.0", features = [
"trace",
"logs",
"metrics",
] }
opentelemetry-http = "0.11.1"
opentelemetry-stdout = { version = "0.3.0", features = [
opentelemetry-http = "0.12.0"
opentelemetry-stdout = { version = "0.4.0", features = [
"trace",
"logs",
"metrics",
] }
opentelemetry-appender-tracing = { version = "0.3.0" }
opentelemetry-prometheus = "0.15.0"
opentelemetry-appender-tracing = { version = "0.4.0" }
opentelemetry-prometheus = "0.16.0"
phonenumber = "0.3.4"
chrono = "0.4.38"
async-graphql-extension-apollo-tracing = { version = "3.2.15" }
Expand Down
3 changes: 0 additions & 3 deletions src/cli/telemetry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ fn set_logger_provider(
.with_exporter(otlp_exporter(config))
.with_log_config(opentelemetry_sdk::logs::config().with_resource(RESOURCE.clone()))
.install_batch(runtime::Tokio)?
.provider().clone()
,
// Prometheus works only with metrics
TelemetryExporter::Prometheus(_) => return Ok(None),
Expand All @@ -139,8 +138,6 @@ fn set_logger_provider(

let otel_tracing_appender = OpenTelemetryTracingBridge::new(&provider);

global::set_logger_provider(provider);

Ok(Some(otel_tracing_appender))
}

Expand Down
12 changes: 6 additions & 6 deletions tailcall-upstream-grpc/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,17 @@ http-body-util = "0.1.1"
anyhow = "1.0.82"
once_cell = "1.19.0"
tonic-tracing-opentelemetry = "0.18.2"
opentelemetry = { version = "0.22.0", features = ["trace"] }
opentelemetry_sdk = { version = "0.22.1", features = ["trace", "rt-tokio"] }
opentelemetry-semantic-conventions = "0.14.0"
opentelemetry-http = "0.11.1"
opentelemetry-otlp = { version = "0.15.0", features = [
opentelemetry = { version = "0.23.0", features = ["trace"] }
opentelemetry_sdk = { version = "0.23.0", features = ["trace", "rt-tokio"] }
opentelemetry-semantic-conventions = "0.15.0"
opentelemetry-http = "0.12.0"
opentelemetry-otlp = { version = "0.16.0", features = [
"trace",
# required to make grpc requests
"tls-roots",
] }
tracing = "0.1.40"
tracing-opentelemetry = "0.23.0"
tracing-opentelemetry = "0.24.0"
tracing-subscriber = "0.3.18"

[build-dependencies]
Expand Down

1 comment on commit 871c0b9

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running 30s test @ http://localhost:8000/graphql

4 threads and 100 connections

Thread Stats Avg Stdev Max +/- Stdev
Latency 6.62ms 3.20ms 95.14ms 75.36%
Req/Sec 3.83k 202.54 5.30k 92.75%

457528 requests in 30.02s, 2.29GB read

Requests/sec: 15240.29

Transfer/sec: 78.22MB

Please sign in to comment.