Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add contenteditable support #1039

Merged
merged 5 commits into from
Apr 15, 2024
Merged

feat(core): add contenteditable support #1039

merged 5 commits into from
Apr 15, 2024

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Feb 9, 2024

import {Maskito, MaskitoElement, maskitoAdaptContentEditable} from '@maskito/core';

const element: MaskitoElement = maskitoAdaptContentEditable(
    document.querySelector('[contenteditable]'),
);

const maskedInput = new Maskito(element, options);

Closes #958

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Feb 12, 2024

Visit the preview URL for this PR (updated for commit ed8939c):

https://maskito--pr1039-content-editable-h204tlk8.web.app

(expires Sun, 07 Apr 2024 14:43:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 61e4dea776cbea516b68c67840913d2edd88bb90

@nsbarsukov
Copy link
Member Author

@nsbarsukov nsbarsukov force-pushed the content-editable branch 3 times, most recently from bd6b5a8 to 52e2172 Compare March 7, 2024 14:05

This comment was marked as outdated.

@nsbarsukov nsbarsukov changed the title [WIP] feat(core): add contenteditable support feat(core): add contenteditable support Mar 7, 2024
@nsbarsukov
Copy link
Member Author

@vladimirpotekhin @splincode
Guys, we have two possible solution how to add support for contenteditable:

Both PR has many common lines but they propose different approaches.
Let's discuss and choose the final one.

@nsbarsukov nsbarsukov marked this pull request as ready for review March 7, 2024 14:26
@github-actions github-actions bot added the ready to merge ready label Mar 7, 2024
@nsbarsukov nsbarsukov removed the ready to merge ready label Mar 7, 2024
@github-actions github-actions bot added the ready to merge ready label Apr 3, 2024
Co-authored-by: Stanislav Zaycev <[email protected]>
Copy link
Contributor

github-actions bot commented Apr 6, 2024

⛔ E2E result job has failed!

@nsbarsukov nsbarsukov merged commit 0d5bb31 into main Apr 15, 2024
31 checks passed
@nsbarsukov nsbarsukov deleted the content-editable branch April 15, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 - Support for contenteditable inputs
4 participants