Creates UUID, puts into local and sends event to posthog #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This adds the basic functionality to generate a new UUID the first time the user visits the /download/ page which is then put both as a `cookie + localStorage` key entry `UUID`. - Sends `Download page visited` event to posthog - Checks if UUID already present and if not, creates UUID and puts in storage
- Added cookie expiry date to see if it resolves issue causing cookie to not be read across website -> extension
0xDaedalus
reviewed
Oct 19, 2022
| GATSBY_DISCORD_APP_ID="1008427467918295044" |
There was a problem hiding this comment.
This env variable does not seem to be in use
| @@ -56,7 +56,8 @@ | |||
| "react-helmet": "^6.1.0", | |||
| "react-query": "^3.39.1", | |||
| "siwe": "^1.1.6", | |||
| "ulid": "^2.3.0" | |||
| "ulid": "^2.3.0", | |||
| "uuid": "^9.0.0" | |||
There was a problem hiding this comment.
We might consider using the ulid library here instead of importing a new uuid library. Not a blocker.
| Accept: "application/json", | ||
| }, | ||
| }) | ||
| // eslint-disable-next-line no-console |
| }, | ||
| }) | ||
| // eslint-disable-next-line no-console | ||
| console.log("UUID:", retrievedUUID) |
There was a problem hiding this comment.
we don't need a console.log here
|
@zuuring any chance we can do this all |
|
We need further project clarifications before this will deploy ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to use
Import the Posthog event
import { posthogEvent } from "shared/analytics/posthog";Call the function where you need events to fire
posthogEvent("Insert your posthog event title here")Notes
This adds the basic functionality to generate a new UUID the first time the user visits the /download/ page which is then put both as a
cookie + localStoragekey entryUUID.Sends
Download page visitedevent to posthogChecks if UUID already present and if not, creates UUID and puts in storage
Testing
(https://deploy-preview-113--tally-cash.netlify.app/download/)to generate a UUIDApplication > Storage > Cookies >ifUUIDis presenthttps://app.posthog.com/events