Underbridge: Drop updated dApp connections feature flag, further Taho renames #3595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadowfiend
force-pushed
the
underbridge
branch
from
27e663c
to
09c095a
Compare
It is enabled and shall remain so!
Anything that is public API is duplicated as tally and taho, everything else is renamed. Some string constants still say tally_ as checking for breakage requires some extra diligence.:
Shadowfiend
force-pushed
the
underbridge
branch
from
09c095a
to
96b805a
Compare
|
Did some light testing here with dApp connections across a few places, including stake.lido.fi which has direct Taho support. All working well, so going to ship it. |
Merged
hyphenized
reviewed
Aug 16, 2023
| providers: dedupedProviders, | ||
| shouldSetTallyForCurrentProvider( | ||
| shouldSetTally: boolean, | ||
| shouldReload = false | ||
| ) { | ||
| if (shouldSetTally && this.currentProvider !== this.tallyProvider) { | ||
| this.currentProvider = this.tallyProvider | ||
| this.shouldSetTahoForCurrentProvider(shouldSetTally, shouldReload) |
There was a problem hiding this comment.
Do we have to keep shouldSetTallyForCurrentProvider as an alias?
There was a problem hiding this comment.
I went back and forth on this one--it was designed for internal calls, and I'm not sure why a third party would call it. But, it is strictly speaking public API, because it needed to be for us to access it in the first place. I felt safe nixing it since the integrations that do exist are provider-style and wouldn't need this call...
With that said, if you'd feel more comfortable with an alias sticking around, I'll slip it in.
Shadowfiend
added a commit
that referenced
this pull request
Aug 17, 2023
## Highlights - Further performance improvements. - Groundwork to rename backend dApp connection things (for the provider) to Taho naming. ## What's Changed * v0.46.1 by @Shadowfiend in #3598 * Updates to release checklist: Removed Mintkudos test by @andreachapman in #3600 * Revert "Revert "Debounce dispatched state diffs"" by @hyphenized in #3579 * Underbridge: Drop updated dApp connections feature flag, further Taho renames by @Shadowfiend in #3595 **Full Changelog**: v0.46.1...v0.47.0 Latest build: [extension-builds-3601](https://github.com/tahowallet/extension/suites/15160003504/artifacts/866327987) (as of Wed, 16 Aug 2023 19:09:51 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
ENABLE_UPDATED_DAPP_CONNECTIONSfeature flag completely, as well as all related code paths.tallyin the window provider to saytahoinstead, except if they were part of a publicly-visible API. In the latter case, adds atahoequivalent, so that we can phasetallyout at an unspecified later date.Latest build: extension-builds-3595 (as of Tue, 15 Aug 2023 20:01:43 GMT).