-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪄 [QA] Update stage environments #814
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Web3onboard remembers last wallet that was used. If it was MM but MM becomes unavailable then web3onboard will try to auto connect to MM and will fail. So to avoid problem with attempting auto connection to the wallet that is not available on the wallet lists let's just disable autoConnect feature for Metamask for now.
### What Fix Base quest copy
✅ Deploy Preview for taho-development ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Resolves #771 ### What Add Metamask to supported wallets 🦊 🥲 Metamask is visible only if you don't have Taho wallet installed. ![image](https://github.com/tahowallet/dapp/assets/20949277/f75f55a4-70ca-432f-a6a9-eeb7dad99ff3) ### Testing 1. Testing Taho **without** Metamask installed - [x] make sure you are able to connect to Taho - [x] make sure you are able to do transactions (stake, unstake) using Taho - [x] make sure you are able to disconnect and reconnect using Taho 2. Testing Taho **with** Metamask installed - [x] make sure you are able to connect to Taho - [x] make sure you are able to do transactions (stake, unstake) using Taho - [x] make sure you are able to disconnect and reconnect using Taho 3. Testing Metamask **without** Taho installed - [x] make sure you are able to connect to Metamask - [x] make sure you are able to do transactions (stake, unstake) using Metamask - [x] make sure you are able to disconnect and reconnect using Metamask - [x] make sure selecting Taho as connection option fails gracefully
jagodarybacka
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request that upon merging will update stage environments with recent
main
changes.The environments that will be updated:
Read more: Deployment to Production Flow