Skip to content

Commit

Permalink
Merge pull request #5 from tagup/DEV-3371-streamlit-1.26
Browse files Browse the repository at this point in the history
Dev 3371 streamlit 1.26
  • Loading branch information
kylelrichards11 authored Sep 5, 2023
2 parents cf2a0bb + de987f0 commit a22413a
Show file tree
Hide file tree
Showing 953 changed files with 11,071 additions and 4,863 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Bug report
name: 🐛 Bug report
description: Submit a bug report to help us improve Streamlit
labels: ["type:bug", "status:needs-triage"]
body:
Expand Down
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
blank_issues_enabled: false
contact_links:
- name: Documentation request
- name: 📚 Documentation request
url: https://github.com/streamlit/docs/issues/new/choose
about: Let us know how our docs could be better
- name: Streamlit documentation
- name: 📖 Streamlit documentation
url: https://docs.streamlit.io/
about: Learn more about how to use Streamlit
- name: Anything else?
- name: Anything else?
url: https://discuss.streamlit.io/
about: Ask usage questions on the Streamlit community forum
31 changes: 0 additions & 31 deletions .github/ISSUE_TEMPLATE/feature_request.md

This file was deleted.

52 changes: 52 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
name: ✨ Feature request
description: Suggest a feature or enhancement for Streamlit
labels: [type:enhancement]
body:
- type: markdown
attributes:
value: |
Thanks for taking the time to suggest a feature or enhancement for Streamlit!
We really appreciate the community's efforts to improve Streamlit ❤️
- type: checkboxes
attributes:
label: Checklist
description: Please confirm and check all the following options.
options:
- label: I have searched the [existing issues](https://github.com/streamlit/streamlit/issues) for similar feature requests.
required: true
- label: I added a descriptive title and summary to this issue.
required: true
- type: textarea
attributes:
label: Summary
description: Type here a clear and concise description of the feature or enhancement request. Aim for 2-3 sentences.
validations:
required: true
- type: textarea
attributes:
label: Why?
description: Please outline the problem, motivation, or use case related to this feature request.
placeholder: |
I'm always frustrated when ...
validations:
required: false
- type: textarea
attributes:
label: How?
description: |
Please describe the solution or implementation you'd like to see. This might include suggestions for `st` commands, new parameters, or UI mockups.
Don't worry if you don't have a clear solution in mind; any input helps!
placeholder: |
Introduce a new command called `st.foo` with the following set of parameters...
validations:
required: false
- type: textarea
attributes:
label: Additional Context
description: |
Links? References? Anything that will give us more context about the feature request here!
For example, did this feature request come from https://discuss.streamlit.io or another site? Link the original source here!
_Tip: You can attach images by clicking this area to highlight it and then dragging files in._
validations:
required: false
51 changes: 51 additions & 0 deletions .github/workflows/community-voting.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
# This workflow automatically comments on issues labeled with 'type:enhancement' or 'type:bug'
# and adds a thumbs-up reaction to the issue to encourage community voting.

name: Community voting
on:
issues:
types:
- labeled
jobs:
add-enhancement-comment:
if: github.event.label.name == 'type:enhancement'
runs-on: ubuntu-latest
permissions:
issues: write
steps:
- name: Add comment to issue
run: gh issue comment ${{ github.event.issue.html_url }} --body "$ISSUE_BODY"
env:
GH_TOKEN: ${{ github.token }}
ISSUE_BODY: |
**To help Streamlit prioritize this feature, react with a 👍 (thumbs up emoji) to the initial post.**
Your vote helps us identify which enhancements matter most to our users.
![Visits](https://hits.seeyoufarm.com/api/count/incr/badge.svg?url=https%3A%2F%2Fgithub.com%2Fstreamlit%2Fstreamlit%2Fissues%2F${{ github.event.issue.number }}&title=visits&edge_flat=false)
- name: Upvote issue
uses: aidan-mundy/react-to-issue@14d172c22f28fabdd86b3458b1701ba1a684bc19
with:
issue-number: ${{ github.event.issue.number }}
reactions: "+1"
add-bug-comment:
if: github.event.label.name == 'type:bug'
runs-on: ubuntu-latest
permissions:
issues: write
steps:
- name: Add comment to issue
run: gh issue comment ${{ github.event.issue.html_url }} --body "$ISSUE_BODY"
env:
GH_TOKEN: ${{ github.token }}
ISSUE_BODY: |
**If this issue affects you, please react with a 👍 (thumbs up emoji) to the initial post.**
Your feedback helps us prioritize which bugs to investigate and address first.
![Visits](https://hits.seeyoufarm.com/api/count/incr/badge.svg?url=https%3A%2F%2Fgithub.com%2Fstreamlit%2Fstreamlit%2Fissues%2F${{ github.event.issue.number }}&title=visits&edge_flat=false)
- name: Upvote issue
uses: aidan-mundy/react-to-issue@14d172c22f28fabdd86b3458b1701ba1a684bc19
with:
issue-number: ${{ github.event.issue.number }}
reactions: "+1"
75 changes: 75 additions & 0 deletions .github/workflows/playwright.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
name: Playwright E2E Tests

on:
push:
branches:
- "develop"
pull_request:
types: [opened, synchronize, reopened]
# Allows workflow to be called from other workflows
workflow_call:
inputs:
ref:
required: true
type: string

# Avoid duplicate workflows on same branch
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-playwright
cancel-in-progress: true

jobs:
test:
runs-on: ubuntu-latest-4-cores

defaults:
run:
shell: bash --login -eo pipefail {0}

steps:
- name: Checkout Streamlit code
uses: actions/checkout@v3
with:
ref: ${{ inputs.ref }}
persist-credentials: false
submodules: "recursive"
fetch-depth: 2
- name: Set Python version vars
uses: ./.github/actions/build_info
- name: Set up Python ${{ env.PYTHON_MAX_VERSION }}
uses: actions/setup-python@v4
with:
python-version: "${{ env.PYTHON_MAX_VERSION }}"
- name: Setup virtual env
uses: ./.github/actions/make_init
- name: Run make develop
run: make develop
- name: Run make protobuf
run: make protobuf
- name: Run make frontend
run: make frontend-fast
- name: Run make playwright
run: make playwright
- name: Check that all screenshot have been committed
run: |
set -x;
UNTRACKED_FILE_COUNT=$(git ls-files --others --exclude-standard | grep snapshots | wc -l | bc -l || echo '0')
echo "Untracked files count: ${UNTRACKED_FILE_COUNT}"
if [[ "${UNTRACKED_FILE_COUNT}" -gt 0 ]]; then
echo "Untracked files:";
git ls-files --others --exclude-standard | grep snapshots;
exit 1;
fi
- name: Upload snapshots
uses: actions/upload-artifact@v3
if: always()
with:
name: playwright_snapshots
path: e2e/playwright/snapshots
- name: Upload failed test results
uses: actions/upload-artifact@v3
if: always()
with:
name: playwright_test_results
path: e2e/playwright/test-results
10 changes: 10 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,16 @@ lib/Pipfile.lock
########################################################################
.idea

########################################################################
# Playwright
########################################################################
# Playwright test
e2e/playwright/playwright-report
e2e/playwright/test-results
# Only keep the snapshots in the linux folder
e2e/playwright/snapshots/*
!e2e/playwright/snapshots/linux

########################################################################
# Cypress
########################################################################
Expand Down
19 changes: 17 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,14 @@ conda-distribution:
GIT_HASH=$$(git rev-parse --short HEAD) conda build lib/conda-recipe --output-folder lib/conda-recipe/dist

.PHONY: conda-package
# Build lib and frontend, and then run 'conda-distribution'
conda-package: build-deps frontend conda-distribution
# Build lib and (maybe) frontend assets, and then run 'conda-distribution'
conda-package: build-deps
if [ "${SNOWPARK_CONDA_BUILD}" = "1" ] ; then\
echo "Creating Snowpark conda build, so skipping building frontend assets."; \
else \
make frontend; \
fi
make conda-distribution;

.PHONY: clean
# Remove all generated files.
Expand All @@ -221,6 +227,7 @@ clean:
rm -rf frontend/public/reports
rm -rf frontend/lib/dist
rm -rf ~/.cache/pre-commit
rm -rf e2e/playwright/test-results
find . -name .streamlit -type d -exec rm -rfv {} \; || true
cd lib; rm -rf .coverage .coverage\.*

Expand Down Expand Up @@ -327,6 +334,14 @@ jscoverage:
e2etest:
./scripts/run_e2e_tests.py

.PHONY: playwright
# Run playwright E2E tests.
playwright:
python -m playwright install --with-deps; \
cd e2e/playwright; \
rm -rf ./test-results; \
pytest --browser webkit --browser chromium --browser firefox --video retain-on-failure --screenshot only-on-failure --output ./test-results/ -n auto -v

.PHONY: loc
# Count the number of lines of code in the project.
loc:
Expand Down
14 changes: 14 additions & 0 deletions NOTICES
Original file line number Diff line number Diff line change
Expand Up @@ -18529,6 +18529,20 @@ SOFTWARE.

-----

The following software may be included in this product: uuid. A copy of the source code may be downloaded from https://github.com/uuidjs/uuid.git. This software contains the following license and notice below:

The MIT License (MIT)

Copyright (c) 2010-2020 Robert Kieffer and other contributors

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

-----

The following software may be included in this product: validate.io-array. A copy of the source code may be downloaded from git://github.com/validate-io/array.git. This software contains the following license and notice below:

The MIT License (MIT)
Expand Down
6 changes: 3 additions & 3 deletions component-lib/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4103,9 +4103,9 @@ which@^2.0.1:
isexe "^2.0.0"

word-wrap@~1.2.3:
version "1.2.3"
resolved "https://registry.yarnpkg.com/word-wrap/-/word-wrap-1.2.3.tgz#610636f6b1f703891bd34771ccb17fb93b47079c"
integrity sha512-Hz/mrNwitNRh/HUAtM/VT/5VH+ygD6DV7mYKZAtHOrbs8U7lvPS6xf7EJKMF0uW1KJCl0H701g3ZGus+muE5vQ==
version "1.2.5"
resolved "https://registry.yarnpkg.com/word-wrap/-/word-wrap-1.2.5.tgz#d2c45c6dd4fbce621a66f136cbe328afd0410b34"
integrity sha512-BN22B5eaMMI9UMtjrGd5g5eCYPpCPDUy0FJXbYsaT5zYxjFOckS53SQDE3pWkVoWpHXVb3BrYcEN4Twa55B5cA==

wordwrapjs@^4.0.0:
version "4.0.1"
Expand Down
Loading

0 comments on commit a22413a

Please sign in to comment.