Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-289: Replace old metadata with metadata from new file #304

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

renato2099
Copy link
Collaborator

@renato2099 renato2099 commented Sep 24, 2023

This PR overrides previous metadata with metadata belong to the new file.
Given that metadata tends to be a few rows (< 100), then this PR removes the old metadata and writes the new metadata.

@lewismc take a look whenever you get some time and we can even take this PR for a spin

@lewismc
Copy link
Member

lewismc commented Sep 30, 2023

Still need to try this one out @renato2099 . We can sync maybe on Sunday?

@lewismc
Copy link
Member

lewismc commented Sep 30, 2023

Nice work!

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@renato2099
Copy link
Collaborator Author

renato2099 commented Sep 30, 2023

hey @lewismc , yeah mate, we can catch up on Sunday, give a ring whenever you are around
I added a couple more unit tests to make the PR comply with Sonar :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants