-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RVV compile option to enable decoding vector instructions #357
Conversation
We should compare / consolidate this with the
|
…ow resides in the vector coprocessor source tree
RVVec.h,. the vector instruction implementations, no longer exists in the rev source tree. The now independent coprocessor now includes this header so we can remove the #ifdef REVVEC code block. ( Tested with 'solo' branch in r2v2 repo ) |
I was mainly speaking of the I don't think we need the |
There are no other REVVEC defines. If nobody has an issue with have the V extension parsing on by default ( I don't ) then we can just remove the RVV define as well and not require any special compile. |
I would prefer if we didn't have to build Rev differently. I think the parsing of the |
I agree. My last push removes the RVV define. So this PR is essentially just removing REVVEC. From every other users' standpoint it is identical to the devel branch. |
This PR adds a compile option, RVV, to allow REV to be built to support the vector coprocessor. This PR is required for a forthcoming PR in the R2V2 repository that decouples that design from the REV source tree.