From develop #143
Closed
From develop #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a new `develop` git workflow it turned out Actions don't run on PRs to branches except for `main`.
npm audit complains about several vulnerabilities. This patch is the result of `npm audit fix`. Fix for `next` requires major version update, isn't critical, and we plan to get rid of it anyway, so it wasn't updated.
"Prepare commit message" hook runs not only on commit, but also on a variety of other git tasks such as rebase and merge, sometimes in an automated way from IDE (Jetbrains IDEs do that). git-cz utility wasn't built with this in mind, and leads to bad developer experience. We can use already existing `npm run commit` script for this. Also `"prepare"` npm hook runs when a package is packaged (`npm pack`), and `husky` is intended to be run on install.
rahulyadav-57
force-pushed
the
staging
branch
from
fe03e4d to
44f74b5
Compare
|
what is the status of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ended up with 2 dev branches.
These are fixes from
develop, merged intostaging.